"Inner Circle" HSI - SIOC DC Motors Card Script

[fordgt40]

Jack

You are in danger of compounding error on error. The logic is flawed in at least one place, as per your last para above. Please take Nico`s advice - stop coding and rethink.

David

[kiek]

No the subroutine has no effect at all (no output), that must be caused by something else.

Yes I said that you should put the logic for motor control in the subroutine. Of course I meant the right logic, not yours.

And now I really stop with this thread, I've had enough of it

[Boeing 747 Flyer]

Okay, how's this?

Var 0, Value 0
{
 &Motor4 = 201
}

Var 0004, name Motor4, Link USB_DCMOTOR, Output 4

Var 49, name P, Link SUBRUTINE,
{
 C0 = &CRS = 0
 C1 = &CRS = 360
 IF C0 OR C1
 {
  IF &A42 = 130
  {
   &Motor4 = 129
  }
   ELSE
   {
    &Motor4 = 201
   }
 }
}

Var 0005, name CRS, Link FSUIPC_IN, Offset $0C4E, Length 2
{
 CALL &P
}

Var 58, name A42, Link USB_ANALOGIC, Input 4, PosL 0, PosC 127, PosR 250
{
 CALL &P
}

I appreciate you have stopped commenting on this thread. but just a simple "Yes" (if I have got your subrutine idea correct) or "No" (if I have still not done what you said) would suffice, if you are still willing.

Jack

[Boeing 747 Flyer]

YEEEEAAAAHHAAAAA!

I finally got it working with TWO degrees now.

The CRS pointer now stops at 355 and 360 degrees. And, although laborious, I am starting the process of doing all 359 degrees.

Woo!

This was my final script.

The 360 degree script:

Var 0, Value 0
{
 &Motor4 = 201
 &control = 0
 &control = TIMER 1 0 5
}

Var 158 name control Link SUBRUTINE
{
 CALL &P2
}

Var 0004, name Motor4, Link USB_DCMOTOR, Output 4

Var 49, name P, Link SUBRUTINE,
{
 IF &Motor4 = 129
 {
  C0 = &CRS < 360
  C1 = &CRS > 0
  IF C0 AND C1
  {
   IF &A42 = 130
   {
    &Motor4 = 201
   }
  }
 }
}

Var 0005, name CRS, Link FSUIPC_IN, Offset $0C4E, Length 2
{
 CALL &P
}

Var 58, name A42, Link USB_ANALOGIC, Input 4, PosL 0, PosC 127, PosR 250
 {
 C0 = &CRS = 0
 C1 = &CRS = 360
 IF C0 OR C1
 {
  IF &A42 = 130
  {
   &Motor4 = 129
  }
   ELSE
   {
    &Motor4 = 201
   }
 }
}

The 355 degree script:

Var 49, name P1, Link SUBRUTINE
{
 IF &Motor4 = 129
 {
  C0 = &CRS1 < 355
  C1 = &CRS1 > 355
  IF C0 OR C1
  {
   IF &A42 = 134
   {
    &Motor4 = 201
   }
  }
 }
}

Var 0005, name CRS1, Link FSUIPC_IN, Offset $0C4E, Length 2
{
 CALL &P1
}

Var 50, name P2, Link SUBRUTINE,
{
 IF &CRS = 355
 {
  IF &A42 = 134
  {
   &Motor4 = 129
  }
   ELSE
   {
    &Motor4 = 201
   }
 }
}

Both of the above were compiled together.

So yes, everything is working! For now...

[kiek]

but just a simple "Yes" (if I have got your subrutine idea correct) or "No" (if I have still not done what you said) would suffice, if you are still willing.

YES, this is what I meant, but you should update the body of Subroutine P with the right logic.

Regarding your second post with as well a subroutine P1 as a subroutine P2: NO THAT'S NOT RIGHT! Now again you have created more places where you control the motor, don't do that.! Do not write 360 scripts (which is not very efficient, to say the least ..............) , but write ONE control script in subroutine P.
I could write it in an hour, but I'll leave it to you as an exercise.

Nico